Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jsonrpc when merge is enabled #4161

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 15, 2022

Enable JsonRpc if disabled and if merge is enabled.

Changes:

  • Enable jsonrpc config and disable url without engine api if merge is enabled and jsonrpc is disabled.
  • Throw an exception if no engine rpc module is configured at all.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

  • Verified engine api endpoint is open when json rpc config is enabled.
  • Verified exception is thrown when no url with engine api is configured.

Further comments (optional

  • We can also, don't update the config and just throw validation error.
  • We can also, replace the whole config with a default merge jsonrpc config.


if (!hasEngineApiConfigured)
{
throw new ArgumentException("No RPC module for engine api configured");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe more of InvalidOperationException or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@LukaszRozmej LukaszRozmej merged commit 9e040e6 into master Jun 15, 2022
@LukaszRozmej LukaszRozmej deleted the enable-jsonrpc-when-merge-is-enabled branch June 15, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execution engine port "already in use" should be a critical error
2 participants