Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable snap sync if state has ever been sycned #4172

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jun 17, 2022

Resolves #4108

Changes:

  • Enable SnapSync for mainnet and goerly by default
  • Disable snap sync if the node has been already fully synced before

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Manual testing should cover:

  • Load the state without snapsync, turn off the node, enable SnapSync, run again. SnapSync should not run

@LukaszRozmej LukaszRozmej merged commit b17f1ef into master Jun 17, 2022
@LukaszRozmej LukaszRozmej deleted the feature/enable-snapsync-for-mainnet-goerli branch June 17, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Snap Sync if State is up to date
2 participants