Update hive tests for gray glacier #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tests are failing due to missing merge instance here: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Ethereum.Test.Base/JsonToEthereumTest.cs#L58 |
* London instance as a placeholder for the merge * fix access list tests * fix access list check
This reverts commit cf94a8b.
tanishqjasoria
approved these changes
Jun 28, 2022
avalonche
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Update hive tests for gray glacier * Fix/merge instance (#4204) * London instance as a placeholder for the merge * fix access list tests * fix access list check * Print general tests results * Revert "Print general tests results" This reverts commit cf94a8b. * Add support for post-merge tests * small refactors * fix some warnings to run pipeline Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updates hive tests
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??