Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge/fix orphaned blocks #4226

Merged
merged 13 commits into from
Jul 1, 2022
Merged

Merge/fix orphaned blocks #4226

merged 13 commits into from
Jul 1, 2022

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Jun 29, 2022 •
edited
Loading

Changes:

  • add BlockTreeLookupOption DoNotCalculateTotalDifficulty and use in NewPayload and FCU

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

MarekM25
MarekM25 reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, consider adding tests

@marcindsobczak marcindsobczak changed the title [WIP] Merge/fix orphaned blocks Merge/fix orphaned blocks Jun 30, 2022
@MarekM25 MarekM25 self-requested a review July 1, 2022 09:50
@marcindsobczak marcindsobczak marked this pull request as ready for review July 1, 2022 10:34
@MarekM25 MarekM25 merged commit 4f84c54 into master Jul 1, 2022
@MarekM25 MarekM25 deleted the merge/fix_orphans branch July 1, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcindsobczak @MarekM25