Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/trace filter #4229

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Fix/trace filter #4229

merged 6 commits into from
Jul 6, 2022

Conversation

tanishqjasoria
Copy link
Contributor

@tanishqjasoria tanishqjasoria commented Jun 30, 2022

Resolves #4127

Changes:

Filter traces after execution to account for internal transactions
Removed Reward traces from trace_filter outpt

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@tanishqjasoria tanishqjasoria marked this pull request as ready for review July 1, 2022 12:14
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you crosstested it with OpenEthereum? You can do that on xdai/gnosis chain

@LukaszRozmej LukaszRozmej merged commit 98b09ab into master Jul 6, 2022
@LukaszRozmej LukaszRozmej deleted the fix/trace-filter branch July 6, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC: trace_filter ignores params ToAddress / FromAddress
2 participants