MSF8 fixes #4242
Merged
MSF8 fixes #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Fix FCU to properly handle this situation.
MarekM25
reviewed
Jul 5, 2022
| _blockCacheService.FinalizedHash = forkchoiceState.FinalizedBlockHash; | ||
| _mergeSyncController.StopBeaconModeControl(); | ||
|
|
||
| if (_logger.IsInfo) { _logger.Info($"Syncing beacon headers... Request: {requestStr}."); } |
There was a problem hiding this comment.
hmmm ok, but it still could be something different than "Syncing beacon headers..." I will think about better logging
MarekM25
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fix NewPayloadV1Handler to answer Syncing when processing timeout hits. Fix FCU to properly handle this situation.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??