Ethstats fix for gnosis devnet #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
commented
Jul 7, 2022
| @@ -148,6 +153,7 @@ private IEnumerable<UInt256> GetGasPricesFromRecentBlocks(IEnumerable<Block> blo | |||
|
|
|||
| if (txFromCurrentBlock == 0) | |||
| { | |||
| blocksToGoBack--; | |||
There was a problem hiding this comment.
Did we have any reason for not decreasing it for empty blocks? In gnosis devnet when we have 100% of blocks empty we're iterating through entire BlockTree over and over https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Eth/GasPrice/GasPriceOracle.cs#L111
There was a problem hiding this comment.
The idea was to try calculate gas price from real transactions instead of empty blocks, but yeah if most are empty then its a problem
LukaszRozmej
approved these changes
Jul 7, 2022
marcindsobczak
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.