Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pruning scenario #4295

Merged
merged 4 commits into from
Jul 20, 2022
Merged

More pruning scenario #4295

merged 4 commits into from
Jul 20, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jul 19, 2022

  • Added more pruning test scenario.

Changes:

  • Added test for sidechain of at least lenght 2.
  • Added test with two consecutive sidechain.
  • Added test which trigger memprune but not persist.
  • Fixes trie exception on the scenario.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap asdacap requested a review from MarekM25 July 19, 2022 07:34
@MarekM25 MarekM25 merged commit 5f9eeb4 into master Jul 20, 2022
@MarekM25 MarekM25 deleted the more-pruning-scenario branch July 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants