Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid block interceptor intercepted wrong block #4300

Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jul 21, 2022

Fix invalid block interceptor intercep generated block instead of suggested block. This is a problem because well crafted block can essentially hang block processing by sending an invalid block which when processed result in a hash of a valid block on main chain.

Changes:

  • Mark suggested block as invalid instead of generated block.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

This seems to be a cause of failed hive test on a different branch when trying to move NP to ACCEPTED where possible, but for some reason, not on master.

@asdacap asdacap requested a review from MarekM25 July 21, 2022 09:05
@asdacap asdacap merged commit c4f9be8 into master Jul 21, 2022
@asdacap asdacap deleted the fix-invalid-block-interceptor-intercepting-wrong-block branch July 21, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants