Remove TrieStore allocations by using ArrayPoolList #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactors
asdacap
approved these changes
Aug 2, 2022
|
|
||
| List<BlockCommitSet> candidateSets = new(); | ||
| while (_commitSetQueue.TryDequeue(out BlockCommitSet? frontSet)) | ||
| using ArrayPoolList<BlockCommitSet> toAddBack = new(_commitSetQueue.Count * 2); |
There was a problem hiding this comment.
To have headroom if the queue grows during pruning, with reallocating List it might not be needed, what do you think?
Default ArrayPool gives you I think at least 8, plus gives you always power of 2.
There was a problem hiding this comment.
Also feel free to review ArrayPoolList code, though it is used in our code without issues already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??