Fix downloader hangs in some case #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Aug 4, 2022
| @@ -475,7 +486,13 @@ protected async Task RequestReceipts(PeerInfo peer, CancellationToken cancellati | |||
| for (int i = 0; i < result.Length; i++) | |||
| { | |||
| TxReceipt[] txReceipts = result[i]; | |||
| if (!context.TrySetReceipts(i + offset, txReceipts, out Block block)) | |||
| Block block = context.GetBlockByRequestIdx(i + offset); | |||
| if (block.Header.HasBody && block.Transactions.Length == 0) | |||
There was a problem hiding this comment.
what about unlces only blocks?
LukaszRozmej
approved these changes
Aug 4, 2022
| @@ -172,6 +172,11 @@ bool HasMoreToSync() | |||
| Block currentBlock = blocks[blockIndex]; | |||
| if (_logger.IsTrace) _logger.Trace($"Received {currentBlock} from {bestPeer}"); | |||
|
|
|||
| if (currentBlock.Header.HasBody && currentBlock.Body.IsEmpty) | |||
There was a problem hiding this comment.
This is now duplicated in 3 places, should we have some kind of method for this validation?
There was a problem hiding this comment.
Probably, I'm still good with this expression IMO, still understandable.
There was a problem hiding this comment.
Renamed to currentBlock.IsBodyMissing
asdacap
force-pushed
the
fix-downloader-hang-in-some-case
branch
from
4d65f7f
to
332ce66
Compare
LukaszRozmej
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix downloader hangs when peer response with no body.
Changes:
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...