Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat JsonRpc.GasCap=0 as max cap #4366

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Aug 4, 2022

Fixes #4360

Changes:

The JsonRpc.GasCap is now handled like in Geth, i.e. when it's 0, then the gas limit is set to max.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

The change is in TransactionForRpc.cs. Other files have been modified due to a small refactoring.

@LukaszRozmej LukaszRozmej merged commit b8975ee into master Aug 5, 2022
@LukaszRozmej LukaszRozmej deleted the hotfix/jsonrpc-gascap branch August 5, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: JsonRpc.GasCap behaves differently from Geth's rpc.gascap
2 participants