Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to GetNodeData with unpersisted nodes #4379

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

LukaszRozmej
Copy link
Member

Changes:

  • SyncServer.GetNodeData goes through keystore in order to be able to return not persisted data
  • Add IReadOnlyKeyStore to better handle abstractions

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 0064f35 into master Aug 8, 2022
@LukaszRozmej LukaszRozmej deleted the fix/sync-nodes-from-trie-store branch August 8, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants