Implement support for the "blockHash" parameter #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubo
changed the title
LukaszRozmej
approved these changes
Aug 9, 2022
Comment on lines
+631
to
634
| if (filter.FromBlock == filter.ToBlock) | ||
| fromBlockResult = toBlockResult = _blockFinder.SearchForHeader(filter.ToBlock); | ||
| else | ||
| { |
There was a problem hiding this comment.
Minor-style: One thing that is bothering me and makes it harder to read is the inconsistency of brackets in code blocks in same if-else. if is bracketless and then you have else that is longer block and has {}. Looks weird and inconsistent to me, makes it harder to follow the logic and boundaries at just a glance.
MarekM25
reviewed
Aug 9, 2022
Comment on lines
+40
to
+47
| if (blockHash is null) | ||
| { | ||
| JObject jObject = serializer.Deserialize<JObject>(jsonValue.ToJsonTextReader()); | ||
| FromBlock = BlockParameterConverter.GetBlockParameter(jObject["fromBlock"]?.ToObject<string>()); | ||
| ToBlock = BlockParameterConverter.GetBlockParameter(jObject["toBlock"]?.ToObject<string>()); | ||
| Address = GetAddress(jObject["address"]); | ||
| Topics = GetTopics(jObject["topics"] as JArray); | ||
| FromBlock = BlockParameterConverter.GetBlockParameter(filter["fromBlock"]?.Value<string>()); | ||
| ToBlock = BlockParameterConverter.GetBlockParameter(filter["toBlock"]?.Value<string>()); | ||
| } | ||
| else | ||
| FromBlock = | ||
| ToBlock = BlockParameterConverter.GetBlockParameter(blockHash); |
|
@MarekM25 Tested with Lighthouse. Everything looks alright. I'm going to merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4384
Changes
Added support for the
blockHashparameter to theeth_getLogsRPC method. When this parameter is specified, thefromBlockandtoBlockparameters are ignored if provided.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
In case you checked yes, did you write tests??