Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore AdditionalUrl when EngineUrl specified #4392

Merged
merged 13 commits into from
Aug 9, 2022
Merged

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented Aug 9, 2022

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

  • Ignore AdditionalUrl with engine module when EngineUrl specified
  • Revert configs

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • [ x ] Yes
  • No

In case you checked yes, did you write tests??

  • [ x ] Yes
  • No

@MarekM25 MarekM25 merged commit a7382a7 into master Aug 9, 2022
@MarekM25 MarekM25 deleted the engine-url-parameters branch August 9, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants