Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure invalid blockhash is not tracked #4415

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Aug 12, 2022

Insure invalid blockhash does not get tracked as this could be an attack vector.

Changes:

  • Check in trackers if the error is invalid blockhash.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

  • No regression in hive test.
  • Still syncing goerli....

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@MarekM25 MarekM25 merged commit ed9684d into master Aug 12, 2022
@MarekM25 MarekM25 deleted the ensure-invalid-blockhash-is-not-tracked branch August 12, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants