Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise and optimize the RPC method trace_callMany #4436

Merged
merged 8 commits into from
Aug 19, 2022

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Aug 17, 2022

Fixes #4165. Closes #4419.

Changes:

This is a revised and optimized version of PR #4419.
This also changes trace module from arrays to enumerables to avoid unnecessary allocations.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Besides unit tests, the changes have been tested on Goerli as follows:

  1. Transfer funds from account A to an unused account B and then back to account A. Succeded as expected.
  2. Transfer funds from account A to account B and then from an unused account C to account A. Failed as expected.

@rubo rubo changed the title Trace callmany acc state changes Revise and optimize the RPC method trace_callMany Aug 17, 2022
@rubo
Copy link
Contributor Author

rubo commented Aug 17, 2022

@LukaszRozmej Geth uses debug_traceCall naming. I'm not sure how our naming aligns with the Debug module standardization.

@tanishqjasoria
Copy link
Contributor

@LukaszRozmej Geth uses debug_traceCall naming. I'm not sure how our naming aligns with the Debug module standardization.

this call is part of the trace module that openethereum introduced: https://openethereum.github.io/JSONRPC-trace-module

@LukaszRozmej
Copy link
Member

@LukaszRozmej Geth uses debug_traceCall naming. I'm not sure how our naming aligns with the Debug module standardization.

debug and trace modules are different things and use different formats.

@LukaszRozmej
Copy link
Member

Could you also smoke test other changed tracing methods (they should be fine, but...)

@LukaszRozmej LukaszRozmej marked this pull request as ready for review August 18, 2022 08:46
@LukaszRozmej LukaszRozmej merged commit 7cff49d into master Aug 19, 2022
@LukaszRozmej LukaszRozmej deleted the trace-callmany-acc-state-changes branch August 19, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trace_callMany doesn't allow to trace dependent transactions
4 participants