-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise and optimize the RPC method trace_callMany
#4436
Conversation
trace_callMany
@LukaszRozmej Geth uses |
this call is part of the trace module that openethereum introduced: https://openethereum.github.io/JSONRPC-trace-module |
src/Nethermind/Nethermind.Evm/Tracing/ParityStyle/ParityLikeBlockTracer.cs
Show resolved
Hide resolved
|
Could you also smoke test other changed tracing methods (they should be fine, but...) |
Fixes #4165. Closes #4419.
Changes:
This is a revised and optimized version of PR #4419.
This also changes trace module from arrays to enumerables to avoid unnecessary allocations.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Besides unit tests, the changes have been tested on Goerli as follows: