Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for ancient barriers in eth_syncing #4441

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Check for ancient barriers in eth_syncing #4441

merged 11 commits into from
Aug 26, 2022

Conversation

deffrian
Copy link
Contributor

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

  • If DownloadBodies or DownloadReceipts are enabled eth_syncing will be true until barriers is reached

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • [ x ] Yes
  • No

In case you checked yes, did you write tests??

  • [ x ] Yes
  • No

@deffrian deffrian requested a review from MarekM25 August 18, 2022 19:37
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build and test scenarios with barriers at 0 as well as subscription

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fix pipeline, test + some minor comment

@MarekM25 MarekM25 merged commit 5f0b734 into master Aug 26, 2022
@MarekM25 MarekM25 deleted the eth-syncing branch August 26, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants