Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve native rocksdb dependencies loading #4445

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Aug 19, 2022

Fixes #4039

If Nethermind is downloaded from sources, it's easy to forget to make a library link that fixes RocksDb native dependency loading

Changes:

  • Load libdl.so.2 if libdl.so was not found

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Manual tests

  • The client runs and shutdowns without problems on fresh linux installation after being downloaded as an archive/installed as a ppa package and in any other case too

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make it static in static constructor.

@rubo rubo requested a review from FalcoXYZ August 19, 2022 13:18
Copy link
Contributor

@FalcoXYZ FalcoXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested on Ubuntu 22 arm64, works without the symlink command.

@flcl42 flcl42 force-pushed the bugfix/try-load-libdl-fron-libdl-so-2-if-not-found branch from 4bb2424 to 064c7aa Compare August 22, 2022 10:29
@flcl42 flcl42 merged commit 60f920b into master Aug 22, 2022
@flcl42 flcl42 deleted the bugfix/try-load-libdl-fron-libdl-so-2-if-not-found branch August 22, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On AMD Ubuntu 22.04, can't run nethermind due to missing RocksDB
3 participants