Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make eth_getProof take an array of UInt256 instead of byte[][] #4457

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

smartprogrammer93
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 commented Aug 23, 2022

Fixes #4394

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add json test with trimmed values like 0x1

@LukaszRozmej LukaszRozmej merged commit 41945f6 into master Aug 25, 2022
@LukaszRozmej LukaszRozmej deleted the Fix_eth_getProof branch August 25, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getProof api calculates wrong proof and value
2 participants