UX improvements for Merge configuration #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
requested review from
asdacap,
LukaszRozmej and
marcindsobczak
and removed request for
asdacap and
LukaszRozmej
asdacap
approved these changes
Sep 6, 2022
LukaszRozmej
reviewed
Sep 6, 2022
| @@ -120,7 +131,8 @@ private void EnsureReceiptAvailable() | |||
| { | |||
| if (!syncConfig.DownloadReceiptsInFastSync || !syncConfig.DownloadBodiesInFastSync) | |||
| { | |||
| throw new InvalidOperationException("Receipt and body must be available for merge to function"); | |||
| if (_logger.IsError) _logger.Error("Receipt and body must be available for merge to function. The following configs values should be set to true: Sync.DownloadReceiptsInFastSync, Sync.DownloadBodiesInFastSync"); | |||
| _environment.Exit(1); | |||
There was a problem hiding this comment.
I would create some static ExitCodes class and name those + make unique codes, so if we get info from users we can actually diagnose it easily
There was a problem hiding this comment.
I would create some static ExitCodes class and name those + make unique codes, so if we get info from users we can actually diagnose it easily
Done :)
asdacap
approved these changes
Sep 6, 2022
LukaszRozmej
reviewed
Sep 6, 2022
Comment on lines
22
to
24
| public const int NoEngineModule = 1; | ||
|
|
||
| public const int NoDownloadOldReceiptsOrBlocks = 2; |
There was a problem hiding this comment.
I would divide the errors in some numbers, for example configuration errors would be between 1_000 and 1_999, wouldn't go from 1 :)
marcindsobczak
approved these changes
Sep 6, 2022
LukaszRozmej
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX improvements for merge configuration + log fix