Exit early on error (#4220) #4658
Conversation
| } | ||
| catch (Exception) | ||
| { | ||
| Environment.ExitCode = -1; |
There was a problem hiding this comment.
Don't we want to have more complex exit code differentiation here?
There was a problem hiding this comment.
I sure don't want to add complexity. I'd recommend adding them when you need.
There was a problem hiding this comment.
It seems that recent change when calling Environment.Exit hangs. Added an IExceptionWithExitCode.
There was a problem hiding this comment.
Isn't Exception.HResult potentially enough?
There was a problem hiding this comment.
Did not realize that exist. it seems the range of that value is much largher. Probably not good for this use case.
There was a problem hiding this comment.
Yes it might get trimmed, but when we control it it should be enough?
There was a problem hiding this comment.
Dont know the semantic of that code.
|
@asdacap please check Lukasz comments. |
|
@jmederosalvarado this issue was raised some time ago by Lion. Do we want to include in the Gnosis branch or after the Gnosis merge? |
Exit early on error in steps except for step with "mustInitialize" set to false.
asdacap
force-pushed
the
Exit-early-on-error-(#4220)
branch
2 times, most recently
from
cb62a5a
to
a0d2fde
Compare
* Exit early on error (NethermindEth#4220) Exit early on error in steps except for step with "mustInitialize" set to false. * Fix hanging on exit * Fix exitcode not forwarded * Rollback unintended commit * Trying to invoke build * Fix build Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Created from #4220