Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specification, configs, new transaction type and header fields #4867

Merged
merged 311 commits into from
Jan 21, 2023
Merged

Add specification, configs, new transaction type and header fields #4867

merged 311 commits into from
Jan 21, 2023

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Nov 5, 2022 •
edited

Depends on #4850

EIP-4844 transaction type, fork rules and configs for devnet have been added anticipating transaction serialization, extended validation and processing functionality

Changes:

  • Update transaction structure to hold blob transaction and its network form
  • Add configs
  • Add header field
  • Add spec

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

MarekM25 and others added 21 commits November 2, 2022 23:29
@MarekM25 @rubo
add WithdrawalApplier
135b9f9
@MarekM25 @rubo
Merge branch 'feature/shanghai-eip-4895-withdrawals' of https://githu…
473cd20 
…b.com/nethermindeth/nethermind into feature/shanghai-eip-4895-withdrawals
@rubo
Remove redundant withdrawals hash check
f3be3ea
@rubo
Remove withdrawal check for null
ec2f25d
@rubo
Add withdrawals test chain spec
b00b594
@rubo
Reformat whitespaces
a43ca6d
@MarekM25
add withdrawalApplier to blockchainProcessor
6fd2c3d
@MarekM25
Merge branch 'feature/shanghai-eip-4895-withdrawals' of https://githu…
c0adc96 
…b.com/nethermindeth/nethermind into feature/shanghai-eip-4895-withdrawals

# Conflicts:
#	src/Nethermind/Nethermind.Blockchain.Test/Proofs/WithdrawalTrieTests.cs
#	src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
#	src/Nethermind/Nethermind.Consensus/Withdrawals/IWithdrawalApplier.cs
#	src/Nethermind/Nethermind.Consensus/Withdrawals/ProductionWithdrawalApplier.cs
#	src/Nethermind/Nethermind.Consensus/Withdrawals/ValidationWithdrawalApplier.cs
#	src/Nethermind/Nethermind.Core/BlockHeader.cs
#	src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs
#	src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V2.cs
#	src/Nethermind/Nethermind.Serialization.Rlp/WithdrawalDecoder.cs
#	src/Nethermind/Nethermind.Specs/Forks/15_Shanghai.cs
#	src/Nethermind/Nethermind.State/Proofs/WithdrawalTrie.cs
@MarekM25
add withdrawals to ExecutionPayload
cd18844
@MarekM25
test fixes
d9e2a08
@MarekM25
fix EVM.test
ea9ff25
@MarekM25
fix EthereumTests
78a06d4
@MarekM25
fix Benchmarks.sln
117225f
@rubo
Revise withdrawals representation according to the spec and refactor
37f703c
@rubo
Rename IWithdrawalApplier to IWithdrawalProcessor
176fb16
@rubo
Add tests for withdrawal encoding/decoding
0279db6
@rubo
Rename Recipient to Address
8751876
@rubo
Reformat whitespaces
b49a1df
@rubo
Revise withdrawals length calculation in block encoding
d05c009
@MarekM25
HasBody?
f05fd1e
@rubo
Remove redundant withdrawals hash check
7ecaef2
@flcl42 flcl42 force-pushed the feature/add-blob-spec-fork-and-fields branch from bee00f6 to afb12b4 Compare November 5, 2022 12:55
smartprogrammer93
smartprogrammer93 requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cant use blockNumber as an activation for anything anymore. you should have a timestamp based activation for your fork. we can have a call and i can explain the new mechanism if you would like

flcl42 and others added 14 commits January 18, 2023 15:21
@flcl42
Merge remote-tracking branch 'origin/master' into bugfix/4848-Correct…
2d300c5 
…-usage-of-chain-and-network-ids
@LukaszRozmej
Refactors
fb22da9
@flcl42
Improve CustomSpecProvider ctor
65d4b6c
@flcl42
Merge branch 'bugfix/4848-Correct-usage-of-chain-and-network-ids' of …
52a90ec 
…github.com:NethermindEth/nethermind into bugfix/4848-Correct-usage-of-chain-and-network-ids
@flcl42
Merge remote-tracking branch 'origin/master' into bugfix/4848-Correct…
0c4ca1e 
…-usage-of-chain-and-network-ids
@flcl42
Use test provider
02336ae
@LukaszRozmej
ethstats fix
1f1ed06
@LukaszRozmej
whitespace
fe25564
@flcl42
Merge remote-tracking branch 'origin/master' into bugfix/4848-Correct…
222affe 
…-usage-of-chain-and-network-ids
@LukaszRozmej
Fix
87dc35b
@flcl42
Merge branch 'bugfix/4848-Correct-usage-of-chain-and-network-ids' of …
00459a4 
…github.com:NethermindEth/nethermind into bugfix/4848-Correct-usage-of-chain-and-network-ids
@flcl42
Fix header encoding: loading from genesis
6799333
@flcl42
Merge remote-tracking branch 'origin/bugfix/4848-Correct-usage-of-cha…
3b5362f 
…in-and-network-ids' into feature/add-blob-spec-fork-and-fields
@flcl42
Merge remote-tracking branch 'origin/bugfix/4848-Correct-usage-of-cha…
20dcc0f 
…in-and-network-ids' into feature/add-blob-spec-fork-and-fields
LukaszRozmej
LukaszRozmej reviewed Jan 20, 2023
View reviewed changes
src/Nethermind/Nethermind.Consensus/Validators/TxValidator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Core.Test/Json/TxTypeConverterTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Runner/Nethermind.Runner.csproj Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/HeaderDecoder.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecBasedSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/Forks/17_Cancun.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ReleaseSpec.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/TxValidatorTests.cs Show resolved Hide resolved
Base automatically changed from bugfix/4848-Correct-usage-of-chain-and-network-ids to master January 20, 2023 10:29
@flcl42 flcl42 marked this pull request as ready for review January 20, 2023 15:29
@flcl42 flcl42 merged commit bf29cbf into master Jan 21, 2023
@flcl42 flcl42 deleted the feature/add-blob-spec-fork-and-fields branch January 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@asdacap asdacap Awaiting requested review from asdacap

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees

@kamilchodola kamilchodola

Labels
eip eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@flcl42 @asdacap @MarekM25 @LukaszRozmej @smartprogrammer93 @marcindsobczak @rubo @kamilchodola