Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eth_getLogs returns logs in opposite order when blooms is disabled #5033

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 18, 2022

  • When bloom is disable, eth_getLogs returns logs in opposite block orders. CL don't like this.

Changes:

  • Reverse back the order to match behaviour when bloom is available.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap asdacap force-pushed the fix/eth_getLogs_reverse_order branch from 97a8e6b to 68c46f5 Compare December 26, 2022 00:45
@asdacap asdacap merged commit 07ec8bd into master Dec 27, 2022
@asdacap asdacap deleted the fix/eth_getLogs_reverse_order branch December 27, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants