Fix/deadlock due to TCS setresult behaviour #5055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5043
SyncDispatcher.UpdateState
which locks_feedStateManipulation
, it'sTrySetResult
will continueSyncDispatcher.Start
from line 162 where it wait fordormantTaskLocal
synchronously._feedStateManipulation
lock may continue further intoMergeBlockDownloader.Dispatch
and remains until it attempt to download something (anything async).SyncPeerAllocation.Replaced
is triggered before any download is queue (likely duringChainLevelHelper.GetNextHeaders
as it is IO bound), the replaced event execution will get blocked atSyncDispatcher.UpdateState
as_feedStateManipulation
is not released._allocationLock
is held by the the peer upgrade event.DoDispatch
withTask.Run
or settingTaskCreationOptions.RunContinuationsAsynchronously
will work.Changes:
DoDispatch
withTask.Run
.TaskCreationOptions.RunContinuationsAsynchronously
to bothSyncDispatcher._dormantStateTask
andRequest.CompletionSource
for good measure.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...