Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old configs & chainspec #5064

Merged
merged 4 commits into from
Dec 29, 2022
Merged

Remove old configs & chainspec #5064

merged 4 commits into from
Dec 29, 2022

Conversation

MarekM25
Copy link
Contributor

  • Removed kiln
  • Removed old merge configs
  • Removed yolo_v3
  • Removed goerli nchain
  • Removed ndm chainspecs

@rubo rubo self-requested a review December 29, 2022 16:35
rubo
rubo requested changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@marcindsobczak
Copy link
Contributor

There are few more places with a need to remove, like:
https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.sln#L54
https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Runner.Test/Nethermind.Runner.Test.csproj#L44

@MarekM25
Copy link
Contributor Author

There are few more places with a need to remove, like: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.sln#L54 https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Runner.Test/Nethermind.Runner.Test.csproj#L44

@marcindsobczak @rubo on it :) sorry, I should wait for CI results

@MarekM25 MarekM25 marked this pull request as draft December 29, 2022 16:41
@MarekM25 MarekM25 requested a review from rubo December 29, 2022 17:47
@MarekM25 MarekM25 marked this pull request as ready for review December 29, 2022 17:48
@MarekM25 MarekM25 merged commit e097a4b into master Dec 29, 2022
@MarekM25 MarekM25 deleted the remove_old_merge_configs branch December 29, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo rubo approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarekM25 @marcindsobczak @rubo