Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to RocksDB v7 #5065

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Migrate to RocksDB v7 #5065

merged 4 commits into from
Jan 2, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Dec 29, 2022

Changes

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@rubo rubo mentioned this pull request Dec 29, 2022
12 tasks
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 66.91% // Head: 66.94% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (7335432) compared to base (c6dce52).
Patch coverage: 57.57% of modified lines in pull request are covered.

❗ Current head 7335432 differs from pull request most recent head dc268c7. Consider uploading reports for the commit dc268c7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5065      +/-   ##
==========================================
+ Coverage   66.91%   66.94%   +0.03%     
==========================================
  Files        1968     1969       +1     
  Lines       70564    70621      +57     
  Branches    13118    13126       +8     
==========================================
+ Hits        47215    47276      +61     
+ Misses      19382    19379       -3     
+ Partials     3967     3966       -1     
Impacted Files Coverage Δ
...Nethermind.Blockchain/Synchronization/ISyncPeer.cs 50.00% <ø> (ø)
src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs 64.66% <ø> (+0.63%) ⬆️
...2P/ProtocolHandlers/SyncPeerProtocolHandlerBase.cs 77.72% <ø> (ø)
...twork/P2P/Subprotocols/Snap/SnapProtocolHandler.cs 33.75% <0.00%> (+1.27%) ⬆️
.../Nethermind/Nethermind.Network/ProtocolsManager.cs 78.90% <0.00%> (ø)
...rmind.Synchronization/FastBlocks/BodiesSyncFeed.cs 10.57% <0.00%> (ø)
...nd.Network.Stats/Model/InitiateDisconnectReason.cs 36.84% <36.84%> (ø)
src/Nethermind/Nethermind.Network/PeerManager.cs 87.47% <40.00%> (-0.23%) ⬇️
...d/Nethermind.Synchronization/Peers/SyncPeerPool.cs 82.29% <62.50%> (ø)
....Synchronization/FastBlocks/FastHeadersSyncFeed.cs 53.31% <63.82%> (+1.99%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubo rubo marked this pull request as ready for review December 29, 2022 22:27
@rubo rubo added the rocksdb label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants