Reduce state access for TxPool

[benaadams]

Removes 3 state lookups per txn add

Changes

• Pass Account to AddCore to avoid 2 additional lookups of account
• DeployedCodeFilter doesn't need to look up account removing an additional lookup of account
• Capture closure in constructor to avoid Func allocation per call in UpdateBuckets()
• Use concrete types to avoid enumerator allocations via interface
• Use an intra-block Address -> Account cache
• Reuse a ThreadStatic TxFilteringState rather than allocating each txn
• Drop Linq use in TxPool
• Return UInt256? GasBottleneck change rather than Action to change gas to avoid allocating an Action per gas change
• Only resnapshot on change

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[LukaszRozmej]

Does it make a dent in grafana dashboards?

[benaadams]

Removed the Address -> Account cache

[benaadams]

@LukaszRozmej is a less exotic change now

[marcindsobczak]

Looks good. Worth to run a node for some time to ensure stability before merging

[benaadams]

Does it make a dent in grafana dashboards?

StateDB remains same (as expected as the trie's should be in cache) and State Tree reads drop by 1/4

[LukaszRozmej]

Does it make a dent in grafana dashboards?

StateDB remains same (as expected as the trie's should be in cache) and State Tree reads drop by 1/4

Was Darkpool looking fine ~5%?

[benaadams]

Was Darkpool looking fine ~5%?

Ave 5.7%