-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement debug_standardTraceBlockToFile
method
#5501
Conversation
280e5b4
to
8df8387
Compare
77d2009
to
418b308
Compare
7fbfb89
to
96fc01d
Compare
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeBlockFileTracer.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeBlockFileTracer.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeBlockFileTracer.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeBlockFileTracer.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeTxMemoryTracer.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeTxTracer.cs
Outdated
Show resolved
Hide resolved
Ok I get that file format is probably different, still would love to see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could experiment with other tracers serializing responses directly to Stream's, but this can be explored in future work.
Resolves #2263
Changes
debug_standardTraceBlockToFile
JSON-RPC methodGethLikeTxTracer
class is now abstract with two separate implementations ofGethLikeTxFileTracer
andGethLikeTxMemoryTracer
for file and memory tracing respectivelyGethLikeBlockTracer
class is replaced with two separate implementations ofGethLikeBlockFileTracer
andGethLikeBlockMemoryTracer
for file and memory tracing respectivelyGethTraceOptions
, theDisableMemory
property has been deprecated in favor of the newEnableMemory
, and the newTxHash
has been addedList<string>
toIEnumerable<string>
inITxTracer.SetOperationMemory()
. Hence, the large number of changed files.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Remarks
This PR replaces #4304.
To make the initial review easier, some optimizations have not been applied.