Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/low priority write #5588

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Feature/low priority write #5588

merged 4 commits into from
Apr 24, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Apr 18, 2023

  • When full pruning runs too fast, it will cause some write stalls which will essentially stalls block processing.
  • This add a low priority write flag so that full pruning writes will be of low priority so that other writes is not blocked.

Changes

  • Add low priority write flags.
  • Minor refactor to make read and write with flags consistent.
  • Integrate with rocksdb and copy tree visitor.

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)
  • Optimization
  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Node write rate limited to 100MBps via cgroup. Seems to work.
Graph is (after, before, after)
Screenshot from 2023-04-20 02-16-19

@asdacap asdacap marked this pull request as ready for review April 19, 2023 18:20
@asdacap asdacap merged commit db400f1 into master Apr 24, 2023
@asdacap asdacap deleted the feature/low-priority-write branch April 24, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants