Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable removing tx index on archive #5693

Merged
merged 1 commit into from
May 15, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 15, 2023

  • Removing old tx lookup index saves about 65GB. But archive node probably wants to store everything.

Changes

  • Dont remove old tx lookup index on archive config.

Types of changes

[X] Config change

What types of changes does your code introduce?

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@asdacap asdacap merged commit 76dd8bd into master May 15, 2023
61 checks passed
@asdacap asdacap deleted the config/dont-remove-tx-index-on-archive branch May 15, 2023 07:38
MarekM25 pushed a commit that referenced this pull request May 15, 2023
jmederosalvarado added a commit that referenced this pull request Jun 19, 2023
* Bump to 1.19.0-rc

* Disable removing tx index on archive (#5693)

(cherry picked from commit 76dd8bd)

* Add Shanghai hard-fork settings for Chiado testnet (#5688)

(cherry picked from commit b81686a)

* Split function into small

* If account exists

* Fix test

* AddToBalanceAndCreateIfNotExists

* Add required to sync message

* Extract some execution logic into methods

* start refactor

* continue refactor

* refactor finished?

* Fix: Swap BuyGas and IncNonce in TransactionProcessor

* Tests are all passing

* Fix test attribute

* fix fee paying on system txs

* use [TestCase] on [TestFixture] classes

* Change method ordering in TxProcessor

* Rename blk to header

* Add warning when tx sender doesn't exist

* Fix merge error

* AddToBalanceAndCreateIfNotExists

* Update TransactionProcessor.cs

* fix format

* Delete unused QuickFail

* Add tests

---------

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Nikita Mescheryakov <deffriann@proton.me>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants