Add MCopy to Evm #5791
Merged
Add MCopy to Evm #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Jun 9, 2023
- fixed gas miscalculation - refactored expansion gas calculations
LukaszRozmej
approved these changes
Jun 12, 2023
MarekM25
requested changes
Jun 12, 2023
There was a problem hiding this comment.
@Demuirgos it won't be possible to configure this EIP in chainspec
Demuirgos
force-pushed
the
Eip5656/Add-MCOPY
branch
from
605482a
to
c386c88
Compare
smartprogrammer93
approved these changes
Jun 15, 2023
LukaszRozmej
approved these changes
Jun 16, 2023
MarekM25
reviewed
Jun 20, 2023
- Added one extra test - Update implementation to match opcode change
MarekM25
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?