Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TSTORE and TLOAD opcode values to match Eip1153 updates #5839

Merged
merged 14 commits into from
Jul 7, 2023
Merged

Update TSTORE and TLOAD opcode values to match Eip1153 updates #5839

merged 14 commits into from
Jul 7, 2023

Conversation

Demuirgos
Copy link
Contributor

@Demuirgos Demuirgos commented Jun 20, 2023 •
edited

Changes

  • updates TSTORE/TLOAD opcodes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@Demuirgos Demuirgos changed the title - Update opcode values to match spec Update TSTORE and TLOAD opcode values to match Eip1153 updates Jun 20, 2023
@Demuirgos Demuirgos marked this pull request as ready for review June 20, 2023 11:16
@Demuirgos Demuirgos requested a review from MarekM25 June 20, 2023 11:16
LukaszRozmej
LukaszRozmej requested changes Jun 20, 2023
View reviewed changes
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated Show resolved Hide resolved
benaadams
benaadams reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @LukaszRozmej points out I'd add a gas check at start of trace so the trace doesn't change

src/Nethermind/Nethermind.Evm/VirtualMachine.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Show resolved Hide resolved
Demuirgos and others added 2 commits July 7, 2023 10:04
@Demuirgos @benaadams
Update src/Nethermind/Nethermind.Evm/VirtualMachine.cs
6351393 
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
@Demuirgos @benaadams
Update src/Nethermind/Nethermind.Evm/VirtualMachine.cs
ede1cd1 
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
@MarekM25 MarekM25 merged commit 7bbce2f into master Jul 7, 2023
61 checks passed
@MarekM25 MarekM25 deleted the Eip1153/Update/TransientStorageOpcodes branch July 7, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Demuirgos @benaadams @MarekM25 @LukaszRozmej @smartprogrammer93