Adjust snap request threshold

[asdacap]

• Adjust some request threshold for snap request queuing.
• Reduces the amount no request to dispatch during snap sync, but sync time too inconsistent to know for sure if it affect anything.
• Increase storage queue size before skipping account range request.
• Check for high code queue first before dequeing not full storage queue.

Changes

• Slight refactor.
• Adjust threshold.

Types of changes

What types of changes does your code introduce?

• Optimization
• Refactoring

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

• Definitely can sync.

[benaadams]

Might want to also change this as I think only Geth currently supports Snap; rather than "not Nethermind"?

nethermind/src/Nethermind/Nethermind.Synchronization/Peers/SyncPeerExtensions.cs

Lines 32 to 37 in 03e25c3

	// check if peer supports snap sync
	if ((contexts & AllocationContexts.Snap) != 0)
	{
	// TODO: Remove when Nethermind implements snap server
	return peerInfo.SyncPeer.ClientType != NodeClientType.Nethermind;
	}

[benaadams]

Code formatting :P

[asdacap]

Might want to also change this as I think only Geth currently supports Snap; rather than "not Nethermind"?

nethermind/src/Nethermind/Nethermind.Synchronization/Peers/SyncPeerExtensions.cs

Lines 32 to 37 in 03e25c3

	// check if peer supports snap sync
	if ((contexts & AllocationContexts.Snap) != 0)
	{
	// TODO: Remove when Nethermind implements snap server
	return peerInfo.SyncPeer.ClientType != NodeClientType.Nethermind;
	}

I think we should remove this completely actually.

[LukaszRozmej]

Might want to also change this as I think only Geth currently supports Snap; rather than "not Nethermind"?

nethermind/src/Nethermind/Nethermind.Synchronization/Peers/SyncPeerExtensions.cs

Lines 32 to 37 in 03e25c3

	// check if peer supports snap sync
	if ((contexts & AllocationContexts.Snap) != 0)
	{
	// TODO: Remove when Nethermind implements snap server
	return peerInfo.SyncPeer.ClientType != NodeClientType.Nethermind;
	}

I think we should remove this completely actually.

The idea there was that Nethermind will advertise snap sync protocol when it is syncing, but we don't want to actually sync from Nethermind as it won't serve any data. This is a temporary thing until we implement snap server. Not sure if Besu has similar issue.

[asdacap]

Well, yea. But if we do try to sync from nethermind, it will disconnect us, leaving some space for geth peer.