-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disable tx gossip during sync #5850
Conversation
Benchmarks project compile error
|
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V65/Eth65ProtocolHandler.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/ParallelSync/SyncedTxGossipPolicy.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but we have regression in hive devp2p TestTransaction (nethermind)
https://github.com/NethermindEth/nethermind/actions/runs/5342947680/jobs/9685386532
(other fails are same as on master).
I tried 3 times and we failed that test in all of them
POSDAO tests are both fine
Engine tests are in progress
src/Nethermind/Nethermind.Synchronization.Test/ParallelSync/SyncedTxGossipPolicyTests.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/ParallelSync/SyncedTxGossipPolicy.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/ParallelSync/SyncedTxGossipPolicy.cs
Outdated
Show resolved
Hide resolved
Engine tests are fine (some fails, but nothing more than on master) |
Works now: https://github.com/NethermindEth/nethermind/actions/runs/5344093085/jobs/9688040889 |
Resolves #5391
Changes
ITxGossipPolicy
that can decide if tx's can be gossiped and if particullar transaction can be gossiped (requested feature by user for a plugin)SyncMode
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?