Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning in failed JSON RPC call, when still syncing relevant data #5853

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

LukaszRozmej
Copy link
Member

Changes

  • Suppress warning logs when not yet synced resource is not there when calling eth_ module JSON RPC methods.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: logs

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej marked this pull request as ready for review June 23, 2023 11:56
@LukaszRozmej LukaszRozmej merged commit 6e7e963 into master Jun 27, 2023
61 checks passed
@LukaszRozmej LukaszRozmej deleted the feature/remove_json_rpc_warn_when_syncing branch June 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants