Trie recovery #5861
Merged
Trie recovery #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase timeout
This reverts commit 1c6e52b.
…ry-snap-sync # Conflicts: # src/Nethermind/Nethermind.Init/Steps/InitializeBlockchain.cs # src/Nethermind/Nethermind.Init/Steps/InitializeNetwork.cs # src/Nethermind/Nethermind.Trie/PatriciaTree.cs
…ry-snap-sync # Conflicts: # src/Nethermind/Nethermind.Trie/TrieException.cs
This reverts commit 37f46cf.
LukaszRozmej
requested review from
asdacap,
tanishqjasoria,
benaadams,
MarekM25,
marcindsobczak and
damian-orzechowski
benaadams
reviewed
Jul 21, 2023
src/Nethermind/Nethermind.Synchronization/Trie/HealingStateTree.cs
Outdated
Show resolved
Hide resolved
benaadams
reviewed
Jul 21, 2023
src/Nethermind/Nethermind.Synchronization/Trie/HealingStorageTree.cs
Outdated
Show resolved
Hide resolved
benaadams
reviewed
Jul 21, 2023
src/Nethermind/Nethermind.Synchronization/Trie/HealingTrieStore.cs
Outdated
Show resolved
Hide resolved
benaadams
approved these changes
Jul 21, 2023
marcindsobczak
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Looks good! The only thing I would change is to not keep snap protocol enabled after syncing - IMO we should try to avoid introducing solution which will make nethermind work a bit worse in normal mode to support the feature which is great, but will be used rarely. Worth to try with P2P AddCapability, enable snap protocol only when node is corrupted and request all peers to add satellite protocol
asdacap
reviewed
Jul 25, 2023
asdacap
reviewed
Jul 25, 2023
src/Nethermind/Nethermind.Synchronization/Trie/TrieNodeRecovery.cs
Outdated
Show resolved
Hide resolved
tanishqjasoria
approved these changes
Jul 26, 2023
This won't work as |
MarekM25
added a commit
that referenced
this pull request
Aug 18, 2023
* - Added Eip4788 to ReleaseSpecs - Added Eip4788 wiring to ChainSpecs * - Added passing state to Precompiles - Added Eip4788 stateful precompile * - Adds consensus logic of Eip4788 * - Tests update * - Minor fixes, Missing migration code * - Test improvements * - Test progress, Cleanup * - More tests fixes * - Whitespace fixes * - Attempt fix failing JsonRpc.Tests * - Fix whistespace check failure * - move setup precompile 4788 to instance method - make Instance field in Precompile static generic to match class type * - fix some build issue * - fixed failing tests * - Apply changes * - Fix failing tests * - ws fixes * - Introduce IBeaconBlockRootHandler * - Removed unnecessary "null" default value * - Fixed some naming inconsistensies * - Fix ws problems * - Fix default behavior of beaconBlockRootHandler argument in BlockProcessor.ctor * - fix * - Fix ws * small improvements * Add EngineApiVersions * - refactor PayloadAttributes.Validate * - ws fix * Init beacon root precompile state for genesis (#5982) * - Applied suggested changes * Fix merge * Fix name, whitespaces * Fix expected code * Remove balance set * genesis.json beacon root. * jsonrpc: fix parentBeaconBlockRoot naming, add isEip4788. * Catch args issue * - ignore 0x0b from precompile checks * Ignore for genesis * Don't count RLP wrapper, when calc tx size for pooled txs msg * Revert "Trie recovery (#5861)" This reverts commit a099f0f. * Use main EIP to detect fork * Adding some workarounds * Add system acc * Another workaround * What if zero bloc * Another idea * Another idea * + * + * Another attempt * 1) What * No genesis * 2) H * Revert "Revert "Trie recovery (#5861)"" This reverts commit 1425d3c. * Adhere a formal rule of encoding * Decline payloads with v3 fields * 2) The * Fix 2) The * clarification comment * fix typo in file name * Add RLP testing scenarios * FIx tracer type * - 4788 cleanup * - Make Eip4788 settabe from chainspec * Fix merge * - other tests fixes * Working on review comments * fix build * remove BeaconBlock from precompile list * - moved ParentBeaconBlockRoot type from byte[] to Keccak - removed commented precompile line from VirtualMachine * - fixed some tests - removed deprectated tests * - more cleanup * - adjusted expected size in blob tx size tests * - ws fix * Default addr * more cosmetic stuff * Remove worldState parameter * Revert "more cosmetic stuff" This reverts commit 872bce8. --------- Co-authored-by: Demuirgos <ayman.bouchareb@outlook.fr> Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk> Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If node will be missing in the trie this PR will attempt to recover it for the network.
If there are peers<=eth66 the
HealingTrieStorewill catchTrieNodeExceptionand useGetNodeDataTrieNodeRecoveryto connect to <=eth66 peers and recoverrlpbyhashwithGetNodeData, then store it back in db.If this fails,
HealingStateTreeandHealingStorageTreewill catchMissingTrieNodeExceptionthrown inPatriciaTreedurign traversing and will try to useSnapTrieNodeRecoveryto recover withGetTrieNodes.All this happens only when
BlockchainProcessor.IsMainProcessingThreadistrue.Limitations:
GetNodeDatait might be longer, but forGetTrieNodesthere is hard limit of 128 blocks. Past that time-window recovery is not possible.GetTrieNodesdoesn't currently verify receivedrlpnot sure if it can be added easily.Example logs (ignore
will throwmessage it was for testing):Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes