Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receipt clean up in batch #5870

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Receipt clean up in batch #5870

merged 2 commits into from
Jun 29, 2023

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Jun 28, 2023 •
edited

Changes

  • Remove the tx index in batch (just use existing function)
  • Move PreviousBlock tx remove into same background task

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams requested a review from asdacap June 28, 2023 14:42
@asdacap asdacap merged commit 5a19706 into master Jun 29, 2023
61 checks passed
@asdacap asdacap deleted the Receipt-clean-up branch June 29, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

Assignees
No one assigned
Labels
minor performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benaadams @asdacap