Evm optimisations #5877
Evm optimisations #5877
Conversation
| @@ -2066,6 +2060,10 @@ private CallResult ExecuteCall<TTracingInstructions>(EvmState vmState, byte[]? p | |||
| } | |||
| } | |||
|
|
|||
| if (gasAvailable < 0) | |||
There was a problem hiding this comment.
Don't think any operation can charge 9.2 * 10^18 gas?
There was a problem hiding this comment.
Max would be SHA3 at 1.3 × 10^10 (2^31*6+30) for a 2 GiB SHA3 op
Other methods like create; sstore etc have their own checks
There was a problem hiding this comment.
Also, it could potentially change the workflow and traces? You are manipulating the stack now.
There was a problem hiding this comment.
Out of gas doesn't report stack; only changes I can see is it might report InvalidJumpDestination or AccessViolation as the error instead of OutOfGas for a couple instructions as it now checks those conditions first; though would fail at the same instruction
There was a problem hiding this comment.
That could be seen as more helpful as if you increased the gas, its still going to fail 🤷♂️
|
Hive tests needed too. |
Should be the same, does the outofgas test prior to EndInstructionTrace |
Changes
UInt256and operations on that type when can be done on smaller native type (e.g.ulong)Vector256clears rather thanSpan.Slice.Clear()Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?