Rename SHA3 opcode to KECCAK256

[Demuirgos]

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

• Align with other clients with regards to opcode 0x20 naming : SHA3 -> KECCAK256

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

[smartprogrammer93]

As discussed this reflects the execution spec and how other clients name the opcode

[LukaszRozmej]

Not sure but the reason for the naming might have been compatibility with Parity/OpenEthereum. maybe this will break something in traces from trace module?

[rubo]

maybe this will break something in traces from trace module?

@LukaszRozmej If any old-style tracing compatibility is broken, then it should be addressed in that particular tracer itself. This should've been renamed long ago, the choice of SHA3 was just historical and not for compatibility reasons. This has already been discussed a year ago.

[rubo]

@Demuirgos Update_known_chain_sizes test fails for Goerli. Not sure what's wrong there.

[benaadams]

@Demuirgos Update_known_chain_sizes test fails for Goerli. Not sure what's wrong there.

The date has increased; all tests will now fail