Throttle Eth_ module queue #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
reviewed
Jul 19, 2023
benaadams
approved these changes
Jul 20, 2023
src/Nethermind/Nethermind.JsonRpc/Modules/IRpcModuleProviderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/IRpcModuleProviderExtensions.cs
Outdated
Show resolved
Hide resolved
benaadams
approved these changes
Jul 20, 2023
MarekM25
commented
Jul 21, 2023
| nameof(IEthRpcModule.eth_uninstallFilter) + "). " + | ||
| " If value is set to 0 limit won't be applied.", | ||
| DefaultValue = "500")] | ||
| int RequestQueueLimit { get; set; } |
There was a problem hiding this comment.
@benaadams it is only for non-shared methods, shouldn't we mention it in the config name?
There was a problem hiding this comment.
Mentions the calls its for in the description?
User wouldn't understand what "non-shared" methods are; is an implementation detail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5923
With spam testing
Before change:
Requests per second: 100
Requests sent in total: 100000
Succeeded requests: 4818
Failed requests: 95182
After the change:
Requests per second: 100
Requests sent in total: 100000
Succeeded requests: 57566
Failed requests: 42434
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
We did load testing with eth_call and testing on gateway infra
Optional. Remove if not applicable.
Documentation
Requires documentation update
Auto-updated with a new config parameter. However, would be great to introduce articles Nethermind for RPC Providers
Requires explanation in Release Notes
ToDo...
Remarks
Optional. Remove if not applicable.