Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewPayload timoeut based on config #5970

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

kamilchodola
Copy link
Contributor

@kamilchodola kamilchodola commented Jul 27, 2023

Solves: #5951

Add option to manipulate timeout for newPayload - needed for Block Processing tests in case of some blocks being processed slower than expected.

Changes

  • Add new flag --Merge.NewPayloadTimeout

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

_New parameter which allows to manipulate maximum time to process engine_newPayload requests.
Current default value is 7 seconds.
Usage example:
--Merge.NewPayloadTimeout=10 _

Remarks

Optional. Remove if not applicable.

@kamilchodola kamilchodola marked this pull request as ready for review July 27, 2023 17:23
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test needs to be updated: Nethermind/Nethermind.AccountAbstraction.Test::All_default_values_are_correct

@kamilchodola kamilchodola merged commit c046894 into master Jul 31, 2023
61 checks passed
@kamilchodola kamilchodola deleted the kch/add_newPayload_configurable_timeout branch July 31, 2023 12:51
This was referenced Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants