-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix receipt recovery & migration #5989
Conversation
MissingReceiptsFixVisitor visitor = new MissingReceiptsFixVisitor( | ||
syncConfig.PivotNumberParsed, | ||
MissingReceiptsFixVisitor visitor = new( | ||
syncConfig.AncientReceiptsBarrierCalc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syncConfig.PivotNumberParsed
delegates to syncConfig.PivotNumber
, which is not a read-only field. The pivot number is modified here:
nethermind/src/Nethermind/Nethermind.Merge.Plugin/Synchronization/PivotUpdator.cs
Line 77 in 52d7add
_syncConfig.PivotNumber = updatedPivotBlockNumber.ToString(); |
then, by the time that this code gets executed, the pivot number is not what the user originally configured.
Either way, we should use the AncientReceiptsBarrier
value for this operation.
Fixes #5823
Changes
AncientReceiptsBarrier
as lower bound when fixing receipts.receipt.ContractAddress
by recovering sender.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Added unit test and also tested against user provided scenario on a running client.
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
It would be nice if we could create a unit/integration test for the associated ticket.