Fix accesList handling on Transactions
#6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Legacy does not have an `AccessList` field - Others have an `AccessList` field and should be at least an empty array
- Can create issues if we don't properly reset the field
emlautarom1
commented
Aug 22, 2023
Comment on lines
+41
to
+48
| if (transaction.SupportsAccessList) | ||
| { | ||
| AccessList = transaction.AccessList is null ? Array.Empty<AccessListItemForRpc>() : AccessListItemForRpc.FromAccessList(transaction.AccessList); | ||
| } | ||
| else | ||
| { | ||
| AccessList = null; | ||
| } |
There was a problem hiding this comment.
Main change for this PR: when a Tx supports accessList then AccessList should be non-null; otherwise the field should be always null.
benaadams
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5161
Changes
accessListhandling on Transactions (Generic, Singed Legacy, Signed 2930 and Signed 1559)Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes