Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Nethermind executable rename handling #6039

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Aug 25, 2023

Changes

Added symlinks for Docker files and macOS to support the old Nethermind.Runner name

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tested manually.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Remarks

This is an improvement for the Nethermind executable rename introduced in #5908 and addresses the cases where users use the old entrypoint when deriving from Nethermind Docker file.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add explanation why this is needed?

@rubo
Copy link
Contributor Author

rubo commented Aug 28, 2023

@LukaszRozmej Added in remarks

@rubo rubo merged commit 04a546d into master Aug 28, 2023
61 checks passed
@rubo rubo deleted the hotfix/exec-rename-handling branch August 28, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants