Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON-RPC response streaming #6078

Merged
merged 41 commits into from
Sep 11, 2023
Merged

Fix JSON-RPC response streaming #6078

merged 41 commits into from
Sep 11, 2023

Commits on Sep 1, 2023

  1. Add WebSocketStream 

    - Wrap a `WebSocket` supporting `Stream` operations
    @emlautarom1
    emlautarom1 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    02f9905 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Add single test

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    22b5a90 View commit details
    Browse the repository at this point in the history

  2. Include possible fix notes

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    4589530 View commit details
    Browse the repository at this point in the history

  3. Introduce 'CounterStream' 

    - Decorator that counts the bytes written
    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    7bf17d3 View commit details
    Browse the repository at this point in the history

  4. Do not take ownership of the underlying WebSocket 

    - Do not dispose `_socket`
- When disposing, just send an "end of message"
    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a46d19e View commit details
    Browse the repository at this point in the history

  5. Add 'SendUsingStream' to 'ISocketHandler' 

    - Instead of using 'SendRawAsync' operate on the socket using a 'Stream'
    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    08c0b55 View commit details
    Browse the repository at this point in the history

  6. Add more tests 

    - Restructure tests (IPC, WebSockets)
    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b899b3f View commit details
    Browse the repository at this point in the history

  7. Remove unused safe null operators

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    647d5c0 View commit details
    Browse the repository at this point in the history

  8. Replace implementation with 'Stream's

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    3ae91f3 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into fix/socket_streams

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f7d1b49 View commit details
    Browse the repository at this point in the history

  10. Use Test annotations

    @emlautarom1
    emlautarom1 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    0f6ee5f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Test 'WebSockets' impl

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    28f3741 View commit details
    Browse the repository at this point in the history

  2. Ensure server has finished without using 'Delay's 

    - Test still could be flaky
    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2a2a901 View commit details
    Browse the repository at this point in the history

  3. Add 'NullJsonRpcLocalStats' 

    - Do nothing on 'ReportCall'
- Return default value on 'GetMethodStats'
- Useful during testing
    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    aaeca89 View commit details
    Browse the repository at this point in the history

  4. Initial WebSockets collection tests

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1bcdc39 View commit details
    Browse the repository at this point in the history

  5. Rollback

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    fd906be View commit details
    Browse the repository at this point in the history

  6. Fix test suite 

    - Use delays to synchronize =(
    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    57a74bd View commit details
    Browse the repository at this point in the history

  7. Remove manual synchronization 

    - We already are using delays
    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8d8c510 View commit details
    Browse the repository at this point in the history

  8. Refactor message counting for WebSockets

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8e12e1f View commit details
    Browse the repository at this point in the history

  9. Refactor IPC tests

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3f61ed9 View commit details
    Browse the repository at this point in the history

  10. Test sending collections through IPC

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    edd2566 View commit details
    Browse the repository at this point in the history

  11. Increase test case count

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b5f8d1b View commit details
    Browse the repository at this point in the history

  12. Use 'NullJsonRpcLocalStats' when required

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    50e4273 View commit details
    Browse the repository at this point in the history

  13. Reintroduce streaming

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5acb02e View commit details
    Browse the repository at this point in the history

  14. Send collections using streams

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    30ca4f9 View commit details
    Browse the repository at this point in the history

  15. Invert if branches

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2fee77b View commit details
    Browse the repository at this point in the history

  16. Add tests for 'maxBatchResponseBodySize' option

    @emlautarom1
    emlautarom1 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8d43c89 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Extract 'RandomString' into separate class

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    412f5f0 View commit details
    Browse the repository at this point in the history

  2. Extract random data generation

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b19bbf3 View commit details
    Browse the repository at this point in the history

  3. Separate 'Ipc' from 'WebSocket' tests

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    4462a5d View commit details
    Browse the repository at this point in the history

  4. Reorder fields, rename server

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    0aa8903 View commit details
    Browse the repository at this point in the history

  5. Fix random object usages

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    cdcdb52 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix/socket_streams

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    6b59144 View commit details
    Browse the repository at this point in the history

  7. Remove commented out line

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ae2f097 View commit details
    Browse the repository at this point in the history

  8. Formatting

    @emlautarom1
    emlautarom1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8aa9c14 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Move tests into single file 

    - Remove 'RandomX' classes, prefer methods
    @emlautarom1
    emlautarom1 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1deacd7 View commit details
    Browse the repository at this point in the history

  2. Throw 'InvalidOperationException' when socket is null

    @emlautarom1
    emlautarom1 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c663766 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @emlautarom1
    emlautarom1 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e9482c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Retry WebSockets tests 

    - Might help with flaky tests on CI
    @emlautarom1
    emlautarom1 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fef0597 View commit details
    Browse the repository at this point in the history

  2. Remove retries 

    - It actually has no effect on CI
    @emlautarom1
    emlautarom1 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    65564b7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/socket_streams

    @emlautarom1
    emlautarom1 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c7e67cf View commit details
    Browse the repository at this point in the history