-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Bump pruning size value for unit test #6087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test. What would be a good test? Maybe it should fail if there was not update to this file for more than a month?
From a QA standpoint, the test is fragile by design since it relies on data outside of the test controls. Thus, the behavior of the test cannot be deterministic. Having a test that checks the file updates might work if the pruning size is growing linearly, which I don't know. Ideally, we'd fetch the expected values on every test run, but it may defeat the purpose of the test :) Anyway, currently tests on the master are failing, which means all the PRs are blocked. Maybe we can merge it as-is, and then create a follow-up issue/PR with a long-term solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this are estimates on moving targets, not sure how would you test it
src/Nethermind/Nethermind.Blockchain.Test/KnownChainSizesTests.cs
Outdated
Show resolved
Hide resolved
@LukaszRozmej you can write a test that checks with github hidden folder to verify when the file got last time updated. And fail if it was not updated recently enough. |
Oh, this is a test file already? Sorry, I thought ir was some production code. |
Update_known_chain_sizes
is failing on master, which blocks PR merging to master.Changes
Update_known_chain_sizes
testTypes of changes
What types of changes does your code introduce?
Testing
Requires testing