Eip4788 : Update address and buffer size (Post audit) #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please link the new spec/PR with PR :) it is helpful. Could you check the status of pyspec hive tests? |
MarekM25
reviewed
Sep 15, 2023
| @@ -11,8 +11,8 @@ | |||
| namespace Nethermind.Consensus.BeaconBlockRoot; | |||
| public class BeaconBlockRootHandler : IBeaconBlockRootHandler | |||
| { | |||
| public static UInt256 HISTORICAL_ROOTS_LENGTH = 98304; | |||
| private static readonly Address DefaultPbbrContractAddress = new Address("0xbEac00dDB15f3B6d645C48263dC93862413A222D"); | |||
| public static UInt256 HISTORICAL_ROOTS_LENGTH = 8191; | |||
There was a problem hiding this comment.
oO big change from 98304 to 8191
There was a problem hiding this comment.
yup, I wonder why
edit : from Pr ethereum/EIPs#7672 (comment)
MarekM25
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.