Fix on handshake failure not disconnecting connection

[asdacap]

• When the exception handler did not explicitly handle the exception, the exception will pass down to the next handler, which if its the tail, it'll do nothing.
• This add an explicit disconnect on exception.
• Also fix the method itself throwing exception.

Changes

• Add explicit disconnect on ExceptionCaught
• Wrap trying to get client id string so that on exception, it does nothing.

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

• Yes

If yes, did you write tests?

• Yes

Notes on testing

• Verified with a custom spammer.

[LukaszRozmej]

why does this throw exceptions? Can we have a version that is guaranteed not to throw?

[asdacap]

The Node property throw exception because RemoteId is still missing at this point. Changing that to a nullable might make other place more inconviniecne.

[LukaszRozmej]

Can we handle that in ToString method and not throw exceptions?

[asdacap]

Which ToString? The Node property of the _session that is throwing.

[MarekM25]

Cosmetic: instead of having empty catch we could move the below checks to session bool property:

              if (_node is null)
                {
                    if (RemoteNodeId is null || RemoteHost is null || RemotePort == 0)
                    {

[LukaszRozmej]

Ah can we introduce Session.TryGetNode?

[asdacap]

I just add if (_session.RemoteNodeId != null) in front of it.

[MarekM25]

Don't we need to call base class anymore? Why?

[asdacap]

Calling base class does nothing. It just pass the exception away to the tail.

[MarekM25]

Cosmetic: instead of having empty catch we could move the below checks to session bool property:

              if (_node is null)
                {
                    if (RemoteNodeId is null || RemoteHost is null || RemotePort == 0)
                    {