rename keccak #6197
Merged
rename keccak #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these are the two files that are the important - rest almost everthing is result of renaming. |
tanishqjasoria
requested review from
asdacap,
benaadams,
LukaszRozmej,
jmederosalvarado and
damian-orzechowski
|
Why That seems more for what its used for (i.e. variable name) than what it is (i.e. class name) Pedersen is also a Hash; as is Poseidon; would generic I may have this wrong, but I think a Commitment scheme can use hashes, but a Cryptographic hash function is not necessarily part of a Commitment scheme? |
|
Yes, I think we can rename it to Hash insted of Commitment. |
|
+1 for |
or Hash32? |
|
I vote for Hash256. |
tanishqjasoria
force-pushed
the
replace-keccak-v2
branch
from
c93d35b
to
b587ed1
Compare
add keccak for computation fix test file rename commitment > hash256
tanishqjasoria
force-pushed
the
replace-keccak-v2
branch
from
2265936
to
cd98924
Compare
|
renamed to Hash256, ready for a review! |
LukaszRozmej
approved these changes
Oct 27, 2023
asdacap
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With verkle tree, we would be using Pedersen in instead of Keccak for state related operations.
Also there are other chains, that we plan to support, using differnet commitment schemes (For eg. poseidon).
This PR replaces Keccak with a more generic class Commitment that can be used to represent any commitment scheme (32 bytes).
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Current unittest already cover this properly
Documentation
Requires documentation update
Requires explanation in Release Notes